terraform-aws-ecs-container-definition

what

• remove the null_value code

why

• Terraform 0.12 supports conditional operations with null value

references

• https://www.hashicorp.com/blog/terraform-0-12-conditional-operator-improvements

what

• ECS default behavior is to have this left unset.
• This allows the container to run with the build-specificed USER in the Dockerfile (if set, root by default)

why

• The default behavior is to use the container's USER runtime.
• Defaulting the runtime is a security gap as it can cause containers that were built to run as other users to suddenly start running as root when deployed with this module.

Note, this could break existing container environments running in the wild if they were inadvertently taking advantage of the root access.

What

• Adds the map_environment variable to support an additional way to pass environment variables

Why

• Provides an asked for interface for passing environment variables.

References

• #61
• #63

what

• Make secretOptions optional so the same technique for mount_points is used for log_configuration

why

• Currently the log_configuration has to be set to null otherwise upon an apply, you will see

references

• https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/83

what

• Add DNS Search Domain as an option

why

• Missing option in current module

references

• https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/85

what

Use the same defaults of user and environment as the AWS API defaults

why

Noticed on subsequent applies that user goes from 0 to null and environment goes from [] to null

references

https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/65

what

Previous PR https://github.com/cloudposse/terraform-aws-ecs-container-definition/pull/81 forgot to use local.container_definition_without_null when merging

why

• null is still showing up in the diff

references

• Closes https://github.com/cloudposse/terraform-aws-ecs-container-definition/issues/80

what

• Support a new parameter named var.container_definition which is an object.

why

• This would allow absolutely any parameter to be passed to the module, or to override the behavior of the module on any property

what

• Reduce diff spam and unset defaults

why

• To reduce noise in the terraform plan

what

• Make log_configuration's secretOptions optional

why

• So secretOptions won't need to be set to use the log_configuration

what

• Adds extra_hosts variable

why

• Adds the ability to add hostnames and IP address mappings to the /etc/hosts file on the container.

what

• Remove default port mapping as it is optional

why

• The default port mapping is optional so maintaining a default port 80 mapping didn't make sense.

what

• Change variable "privileged" type to bool

why

• The variable "privileged" is currently type string, which is a holdover from Terraform v0.11/HCL v1. This variable is broken in TF 0.12; it causes an error because the AWS provider was expected a bool true but got a string "true" instead