Server

Bug

• Show Petition and Show Petition_Info fix (#3503) @fryguy503 2023-07-18

Code

• Remove arbitrary teleport blocking in Tutorial and Load zones (#3506) @Valorith 2023-07-19

Databuckets

• Fix issue with expired databuckets not being expired and returned properly (#3504) @Akkadius 2023-07-18

Fixes

• #set title_suffix Argument Position (#3505) @Kinglykrab 2023-07-18

Data Buckets

• Implement scoped data buckets (#3498) @Akkadius 2023-07-16

Fixes

• Fix rule check and add rule for pickpocket command (#3492) @tuday2 2023-07-16

Pathing

• Improvements to roambox logic, pathing (#3502) @Akkadius 2023-07-18

Quest API

• Add SetLDoNPoints() to Perl/Lua (#3496) @Kinglykrab 2023-07-16

Z Clipping

• Don't issue zclip adjustments when NPC is not moving (#3499) @Akkadius 2023-07-16

Database

• Fix database manifest entry for #3443 @neckkola 2023-07-15

Bots

• Remove orphaned commands related to botgroup (#3489) @tuday2 2023-07-09

Commands

• Consolidate #set-like commands into a singular #set command (#3486) @Kinglykrab 2023-07-15

Feature

• Add Support for item textures higher than 65,535 (#3494) @Kinglykrab 2023-07-14
• Update raid features (#3443) @neckkola 2023-07-13

Fixes

• Fix Tradeskill Combines with augmented items (#3490) @Kinglykrab 2023-07-15
• Fix charmed pets to follow when charmed. (#3488) @noudess 2023-07-08
• Update bot naming check and add more explanation (#3491) @tuday2 2023-07-13

Quest API

• Add Mob/Entity type check methods to Perl/Lua (#3493) @Kinglykrab 2023-07-13

Bots

• Add Pickpocket Command (#3484) @tuday2 2023-07-08

Code

• Move #find item summon links to front (#3483) @Kinglykrab 2023-07-05
• Remove LoadItemDBFieldNames() from common/misc.cpp and common/misc.h (#3473) @Kinglykrab 2023-07-04

Commands

• Add #itemsearch alias to #find aliases (#3485) @Kinglykrab 2023-07-08
• Consolidate #show commands into a singular #show command (#3478) @Kinglykrab 2023-07-08

Fixes

• Fix _PutItem having a slot_id of -1 on mobs with no items (#3474) @Kinglykrab 2023-07-04

Rules

• Add Skills:TrivialTradeskillCombinesNoFail Rule (#3481) @JasXSL 2023-07-05

Commands

• Add #emotesearch to #find command (#3480) @Kinglykrab 2023-07-04
• Cleanup #copycharacter Command (#3479) @Kinglykrab 2023-07-04

Fixes

• Add chatchannel_reserved_names to a new manifest (#3482) @Kinglykrab 2023-07-04
• Fix issue in zone store of returning reference to local variable (#3477) @Kinglykrab 2023-07-04

Cleanup/Feature

• Add support for bots to #showstats/#mystats (#3427) @Kinglykrab 2023-07-01

Code

• Remove LoadItemDBFieldNames() from common/misc.cpp and common/misc.h (#3473) @Kinglykrab 2023-07-04
• Remove handle_npc_single_npc from zone/lua_parser_events.cpp and zone/lua_parser_events.h (#3467) @Kinglykrab 2023-07-03

Database

• Set multi statements off when returning early (#3462) @Akkadius 2023-07-01

Feature

• Add Strings::BeginsWith() and Strings::EndsWith() (#3471) @Kinglykrab 2023-07-03

Fixes

• Add check for underscores in botcreate command (#3458) @tuday2 2023-06-29
• EVENT_LANGUAGE_SKILL_UP in Lua was using EVENT_SKILL_UP logic (#3466) @Kinglykrab 2023-07-03
• Fix _PutItem having a slot_id of -1 on mobs with no items (#3474) @Kinglykrab 2023-07-04
• Fix data type of GetAggroCount() (#3470) @Kinglykrab 2023-07-03

Logging

• Fix logging crash when % are sent through query logs (#3461) @Akkadius 2023-07-01

Quest API

• Add ClearAccountFlag() and GetAccountFlags() to Perl/Lua (#3469) @Kinglykrab 2023-07-03
• Add GetClassAbbreviation() and GetRaceAbbreviation() to Perl/Lua (#3463) @Kinglykrab 2023-07-02
• Add GetClassPlural() and GetRacePlural() to Perl/Lua (#3468) @Kinglykrab 2023-07-03
• Add GetCloseMobList() and CalculateDistance() overload to Perl/Lua (#3455) @Kinglykrab 2023-07-02
• Add Hate Entry Methods to Perl (#3459) @Kinglykrab 2023-07-02
• Add ItemData Class to Perl (#3465) @Kinglykrab 2023-07-02
• Add Spawn2 Class to Perl (#3456) @Kinglykrab 2023-07-02
• Add StatBonuses Class to Perl (#3460) @Kinglykrab 2023-07-02
• Add missing Item Methods to Perl/Lua. (#3464) @Kinglykrab 2023-07-02

Code

• Default skill type to Hand to Hand in #npcedit meleetype (#3422) @Kinglykrab 2023-06-19
• Delete common/worldconn.cpp (#3436) @Kinglykrab 2023-06-24
• Remove DatabaseCastAccepted() from zone/npc.cpp and zone/npc.h (#3449) @Kinglykrab 2023-06-24
• Remove GetACAvoid() from zone/merc.h (#3447) @Kinglykrab 2023-06-25
• Remove GetACMit() from zone/merc.h (#3446) @Kinglykrab 2023-06-24
• Remove _ClearWaypints() from zone/npc.h (#3445) @Kinglykrab 2023-06-24
• Remove acmod() from zone/merc.h (#3448) @Kinglykrab 2023-06-24
• Remove command_packetprofile from zone/command.h (#3432) @Kinglykrab 2023-06-24
• Remove command_showpetspell in zone/command.h (#3430) @Kinglykrab 2023-06-24
• Remove command_unlock from zone/command.h (#3431) @Kinglykrab 2023-06-24

Commands

• Add #finddeity Command (#3435) @Kinglykrab 2023-06-26
• Add #findlanguage Command (#3434) @Kinglykrab 2023-06-25
• Add #showspells Command (#3429) @Kinglykrab 2023-06-24
• Add missing subcommands to #npcedit (#3423) @Kinglykrab 2023-06-19
• Cleanup #showbuffs Command (#3439) @Kinglykrab 2023-06-26
• Cleanup #shownpcgloballoot and #showzonegloballoot Commands (#3440) @Kinglykrab 2023-06-24
• Cleanup #viewcurrencies Command (#3441) @Kinglykrab 2023-06-25
• Consolidate #findX commands to a singular #find Command (#3452) @Kinglykrab 2023-06-28
• Consolidate #merchant_close_shop and #merchant_open_shop to #merchantshop (#3433) @Kinglykrab 2023-06-24
• Delete #showbonusstats Command (#3437) @Kinglykrab 2023-06-24
• Delete #spellinfo Command (#3438) @Kinglykrab 2023-06-24

Database

• Fix database version checking edge case issue (#3428) @Akkadius 2023-06-22
• Fix multi-statement error reporting (#3425) @Akkadius 2023-06-19
• Implement native database migrations in server (#2857) @Akkadius 2023-06-19

Fixes

• Fix NPC Item Stat Bonuses (#3444) @Kinglykrab 2023-06-26
• Fix error in 023_01_21_bots_raid_members.sql (#3453) @mibastian 2023-06-28
• Fix possible crash with #npcedit weapon (#3421) @Kinglykrab 2023-06-19
• Merchant Open Flag set only for regular Merchants (#3454) @Kinglykrab 2023-06-27

Readme

• Update new location of database updates (#3424) @joligario 2023-06-19

Rules

• Add ClientPetsUserOwnerNameInLastName rule (#3442) @Kinglykrab 2023-06-25

Fixes

• Fix improper condition in Water LOS checks (#3426) @Kinglykrab 2023-06-19

Database

• Fix multi-statement error reporting (#3425) @Akkadius 2023-06-19

Schema

• Add chatchannel_reserved_names table to database_schema.h

Code

• Default skill type to Hand to Hand in #npcedit meleetype (#3422) @Kinglykrab 2023-06-19

Commands

• Add missing subcommands to #npcedit (#3423) @Kinglykrab 2023-06-19

Database

• Implement native database migrations in server (#2857) @Akkadius 2023-06-19

Fixes

• Fix possible crash with #npcedit weapon (#3421) @Kinglykrab 2023-06-19

Backups

• Move world database:dump to use MySQL credentials file (#3410) @Akkadius 2023-06-17

Binaries

• Add support for static linking (portable) binaries (#3417) @Akkadius 2023-06-18

CI

• Build static linux binaries (#3419) @Akkadius 2023-06-18

CLI

• Add bots:enable and bots:disable commands (#3415) @Akkadius 2023-06-17
• Add mercs:enable and mercs:disable commands (#3416) @Akkadius 2023-06-18
• Console menu validation fixes (#3413) @Akkadius 2023-06-17

Database

• Add query multi statement execution support (#3414) @Akkadius 2023-06-17

Feature

• Add Water Line of Sight Checks (#3408) @nytmyr 2023-06-17

Logging

• Logging improvements, console silencing, terminal coloring (#3412) @Akkadius 2023-06-17

Quest API

• Add convert_money_to_string() to Perl/Lua (#3418) @Kinglykrab 2023-06-18

Strings

• Add more test cases for string utils (#3411) @Akkadius 2023-06-17

Targeting

• Fix bug when using /tar on invalid target (#3407) @noudess 2023-06-17

Telnet

• Add cross zone/world wide cast and move functionality to Telnet (#3409) @Kinglykrab 2023-06-17

Targeting

• Revert #3383 (#3405) @noudess 2023-06-13

Code

• Add GMFind_Struct to packet structures (#3402) @Kinglykrab 2023-06-12
• Remove CHECK_LOS_STEP from zone/common.h (#3398) @Kinglykrab 2023-06-12
• Remove CheckCoordLosNoZLeaps() from zone/entity.cpp and zone/entity.h (#3384) @Kinglykrab 2023-06-12
• Remove CountTempPets() from zone/entity.cpp and zone/entity.h (#3390) @Kinglykrab 2023-06-12
• Remove Evade() from zone/entity.cpp and zone/entity.h (#3394) @Kinglykrab 2023-06-12
• Remove GateAllClients() from zone/entity.cpp and zone/entity.h (#3391) @Kinglykrab 2023-06-12
• Remove GetClient(ip, port) from zone/entity.h (#3386) @Kinglykrab 2023-06-12
• Remove GetClientCount() from zone/entity.cpp and zone/entity.h (#3392) @Kinglykrab 2023-06-12
• Remove GetGroupByBot(), GetRaidByMob(), and GetRaidByLeaderName() from zone/entity.cpp and zone/entity.h (#3387) @Kinglykrab 2023-06-12
• Remove InteractiveChat() and TakenAction() from zone/npc.h (#3382) @Kinglykrab 2023-06-12
• Remove LimitCheckBoth() from zone/entity.cpp and zone/entity.h (#3393) @Kinglykrab 2023-06-12
• Remove NPC::AddCash() from npc.cpp/npc.h (#3380) @Kinglykrab 2023-06-09
• Remove RemoveMob() and RemoveRaid() from zone/entity.cpp and zone/entity.h (#3389) @Kinglykrab 2023-06-12
• Remove SPECIALIZE_MANA_REDUCE from zone/common.h (#3400) @Kinglykrab 2023-06-12
• Remove SendAATimer() from zone/entity.h (#3388) @Kinglykrab 2023-06-12
• Remove WriteEntityIDs() from zone/entity.cpp and zone/entity.h (#3395) @Kinglykrab 2023-06-12
• Remove _BECOMENPCPET() and _NPCPET() from zone/common.h (#3399) @Kinglykrab 2023-06-12
• Remove pDBAsyncWorkID from zone/entity.h (#3385) @Kinglykrab 2023-06-12
• Remove struct DynamicZoneSafeReturn from zone/entity.h (#3396) @Kinglykrab 2023-06-12
• Remove struct TradeEntity from zone/common.h (#3397) @Kinglykrab 2023-06-12

Commands

• Assign #opcode to a #reload alias (#3401) @Kinglykrab 2023-06-12

Illusions

• RandomizeFeatures and SetGender were killing db texture (#3376) @noudess 2023-06-06

Logging

• Fixed statements that logged incorrect data (#3381) @noudess 2023-06-07

Quest API

• Add GetEXPForLevel() to Perl/Lua (#3403) @Kinglykrab 2023-06-12
• Add SendChannelMessage() to Perl/Lua (#3378) @Kinglykrab 2023-06-04
• Add several spell methods to Perl/Lua (#3379) @Kinglykrab 2023-06-12

Targeting

• /tar should not untarget existing target (#3383) @noudess 2023-06-12

Code

• Cleanup #setskill and #setskillall Commands (#3367) @Kinglykrab 2023-05-25
• Delete message.h (#3348) @Kinglykrab 2023-05-17
• Fix #spawn command NPCs having 0 health (#3371) @Kinglykrab 2023-05-21
• Remove CalcPetHp from spdat.h (#3364) @Kinglykrab 2023-05-25
• Remove CountNPC() and QueueManaged() from entity.cpp/entity.h (#3346) @Kinglykrab 2023-05-17
• Remove DumpMerchantList() from zone.cpp/zone.h (#3343) @Kinglykrab 2023-05-17
• Remove GetDamageReceived() and GetHealReceived() from combat_record.cpp/combat_record.h (#3358) @Kinglykrab 2023-05-17
• Remove GetEscapingEntOnHateList() from hate_list.cpp/hate_list.h (#3353) @Kinglykrab 2023-05-17
• Remove GetMaxRank() from aa_ability.cpp/aa_ability.h (#3347) @Kinglykrab 2023-05-25
• Remove IsEntityInFrenzyMode() from hate_list.cpp/hate_list.h (#3352) @Kinglykrab 2023-05-17
• Remove IsRaid() from raids.h (#3361) @Kinglykrab 2023-05-25
• Remove LoadSpawn2() and PopulateZoneSpawnListClose() from spawn2.cpp/zonedb.h (#3344) @Kinglykrab 2023-05-25
• Remove SetGraveyard() from zone.cpp/zone.h (#3354) @Kinglykrab 2023-05-17
• Remove SetTradeCash() from trading.cpp/common.h (#3356) @Kinglykrab 2023-05-17
• Remove TraderUpdate() from trading.cpp/client.h (#3357) @Kinglykrab 2023-05-17
• Remove TypeToSkill() from tradeskills.cpp/object.h (#3355) @Kinglykrab 2023-05-17
• Remove Z_AGGRO from spdat.h (#3365) @Kinglykrab 2023-05-25
• Remove numMembers from raids.h (#3362) @Kinglykrab 2023-05-25
• Set GetAugmentType() to int again (#3335) @Kinglykrab 2023-05-08

Commands

• Add #findcurrency Command (#3368) @Kinglykrab 2023-05-25
• Add entity variable command (#3345) @Kinglykrab 2023-05-25
• Cleanup #setanim (#3350) @Kinglykrab 2023-05-25

Feature

• Intoxication setter/getter for source, getter for Perl/Lua (#3330) @JasXSL 2023-05-03

Fixes

• #augmentitem bypasses augment restrictions (#3332) @Kinglykrab 2023-05-07
• Fix Heroic INT/WIS Bonuses (#3341) @RekkasGit 2023-05-15
• Fix duplicate messages in #npcedit (#3372) @Kinglykrab 2023-05-21
• Fix issue with Group Pointers/Member roles (#3374) @Aeadoin 2023-05-25
• Fix mob item bonus calc (#3334) @Akkadius 2023-05-07
• Fix typos in #zheader (#3370) @Kinglykrab 2023-05-21
• Mob scaling issue with min dmg set to zero while max dmg is not (#3351) @RekkasGit 2023-05-20
• NPC Armor Upgrade to a slot not handled correctly (#3366) @noudess 2023-05-20
• ReloadQuests() on Zone::Init() to avoid cached global quests/plugins (#3333) @Kinglykrab 2023-05-07
• Revert " ReloadQuests() on Zone::Init() to avoid cached global quests/plugins " (#3333) @Akkadius 2023-05-08

Memory Leak

• Fix large memory leak introduced in CalcItemBonuses (#3331) @Akkadius 2023-05-07

Messages

• Remove duplicate heal message for healing yourself (#3329) @noudess 2023-05-03

Performance

• Character bind is now bulk saved (#3338) @Akkadius 2023-05-09
• Character buffs now save in bulk (#3336) @Akkadius 2023-05-09
• Character pet bulk saving (#3337) @Akkadius 2023-05-09
• Character tribute is now bulk saved (#3340) @Kinglykrab 2023-05-25
• Mail key is now cached during player load (#3339) @Akkadius 2023-05-09

Pets

• Fix saving inconsistencies with pets (#3375) @Akkadius 2023-05-25

Quest API

• Add GetHateListClosest(), GetHateListClosestBot(), GetHateListClosestClient(), and GetHateListClosestNPC() methods/overloads to Perl/Lua (#3359) @RekkasGit 2023-05-16
• Add GetPet() to Perl (#3309) @Kinglykrab 2023-05-08
• Add Memorize and Scribe Spell Events to Perl/Lua (#3363) @Kinglykrab 2023-05-25
• Add zone data methods to Perl/Lua (#3342) @Kinglykrab 2023-05-24
• Cleanup The Darkened Sea Quest Methods Names (#3369) @Kinglykrab 2023-05-21

Rules

• Add World:MaximumQuestErrors Rule (#3349) @Kinglykrab 2023-05-21
• ResurrectionEffectBlock to prevent/allow/move buffs. (#3288) @nytmyr 2023-05-08

Code

• Add check for owner in quest::pausetimer() (#3304) @Kinglykrab 2023-04-23
• Add check for owner in quest::resumetimer() (#3305) @Kinglykrab 2023-04-23
• Add initiator/owner checks to various methods in questmgr.cpp (#3306) @Kinglykrab 2023-04-23
• Fix possible nullptr in quest::addloot() (#3303) @Kinglykrab 2023-04-23
• Remove GetClassHPFactor() from zone/client_mods.cpp and zone/client.h (#3313) @Kinglykrab 2023-04-30
• Remove GetClassHPFactor() from zone/merc.h (#3314) @Kinglykrab 2023-04-30
• Remove pDontCastBefore_casting_spell from zone/npc.h (#3311) @Kinglykrab 2023-04-30
• Remove unused code in zone/pets.cpp (#3310) @Kinglykrab 2023-04-30
• Remove unused methods in zone/bot.cpp and zone/bot.h (#3315) @Kinglykrab 2023-04-30
• Remove unused methods in zone/client.cpp and zone/client.h (#3312) @Kinglykrab 2023-04-30
• Remove unused variable in common/crash.cpp (#3308) @Kinglykrab 2023-04-30
• Use default ctor/dtor in oriented_bounding_box.h (#3307) @Kinglykrab 2023-04-30
• quest::createBot() unnecessary check against nullptr (#3302) @Kinglykrab 2023-04-23
• quest::setallskill() had always true condition. (#3301) @Kinglykrab 2023-04-30

Crash

• Fix UCS crash that occurs during log reloading (#3324) @Akkadius 2023-04-30
• Fix possible dereference of nullptr in Client::CalcHPRegen (#3316) @Aeadoin 2023-04-23
• Fix possible nullptr in Client::GetCharMaxLevelFromQGlobal() (#3317) @Kinglykrab 2023-04-23

Discord

• Add Discord webhook callback processing to world (#3322) @Akkadius 2023-04-30

Fixes

• Fix issue with NPCs no longer using some armor. (#3318) @noudess 2023-04-24
• Fix issue with spawning Mercs (#3327) @Aeadoin 2023-04-29
• Possible issues with SummonItem in Client::QuestReward() methods (#3325) @Kinglykrab 2023-04-27

Maps

• Update download with faster releases link (#3321) @Akkadius 2023-04-30

Messages

• Remove duplicate you have lost a level message (#3323) @noudess 2023-04-25

Quest API

• Add GetDefaultRaceSize() overloads to Perl/Lua (#3320) @Kinglykrab 2023-04-30
• Add HasSpellEffect() to Perl/Lua (#3319) @Kinglykrab 2023-04-30

Backups

• Fix database dump error reporting (#3175) @Akkadius 2023-04-04

Bots

• Cleanup GetBotTables() (#3270) @Aeadoin 2023-04-06

Cleanuo

• Only define row if we have results in Database::GetCharacterID() (#3199) @Kinglykrab 2023-04-05

Code

• Add missing breaks and returns in bonuses.cpp (#3231) @Kinglykrab 2023-04-05
• Breaks in wrong spot in cases in spell_effects.cpp (#3297) @Kinglykrab 2023-04-22
• Cleanup always true/false statements in shareddb.cpp (#3189) @Kinglykrab 2023-04-05
• Cleanup cheap-to-copy reference to use value instead in eq_stream_ident.cpp/eq_stream_ident.h (#3209) @Kinglykrab 2023-04-05
• Cleanup discord.cpp and discord_manager.cpp (#3205) @Kinglykrab 2023-04-05
• Cleanup duplicate conditions in negate bonuses in bonuses.cpp (#3226) @Kinglykrab 2023-04-05
• Cleanup item_instance.cpp always true statements and reassigning of same values (#3187) @Kinglykrab 2023-04-05
• Cleanup macros in features.h (#3185) @Kinglykrab 2023-04-05
• Cleanup string -> char* -> string conversions in bot_command.cpp (#3252) @Kinglykrab 2023-04-05
• Cleanup unnecessary condition in Client::SendAlternateCurrencyValue() (#3266) @Kinglykrab 2023-04-05
• Cleanup zone/zoning.cpp (#3289) @Kinglykrab 2023-04-14
• Combine similar cases in Client::InitInnates() (#3260) @Kinglykrab 2023-04-05
• Convert equipable_slot_list to std::vector from std::list in bot_command.cpp (#3253) @Kinglykrab 2023-04-05
• Delete embxs.cpp/embxs.h (#3284) @Kinglykrab 2023-04-14
• Delete unused strings in bot_command.cpp (#3251) @Kinglykrab 2023-04-05
• Fix GetLastName() length check in Client::SendWindow() (#3263) @Kinglykrab 2023-04-05
• Fix always false conditions in Client::IncStats() (#3256) @Kinglykrab 2023-04-05
• Fix check for !this in Client::SendHPUpdateMarquee() (#3257) @Kinglykrab 2023-04-05
• Fix filter condition in attack.cpp (#3218) @Kinglykrab 2023-04-05
• Fix ornamentation augment icons in inspect requests (#3264) @Kinglykrab 2023-04-05
• Fix possible nullptr inst in GetSharedBank() (#3190) @Kinglykrab 2023-04-08
• Fix possible overflows in Client::AddPlatinum() and Client::TakePlatinum() (#3255) @Kinglykrab 2023-04-05
• Fix shared_tasks.cpp/shared_tasks.cpp variable named same as class member (#3192) @Kinglykrab 2023-04-05
• Fix skill_used being used as boolean in Mob::CommonDamage() (#3220) @Kinglykrab 2023-04-05
• Identical conditions right beside each other in aa.cpp (#3213) @Kinglykrab 2023-04-05
• Move unreachable code in ApplySpellsBonuses() (#3229) @Kinglykrab 2023-04-05
• Move variable definition to more relevant scope in DatabaseDumpService::Dump() (#3200) @Kinglykrab 2023-04-05
• Multiple cases with same outcome in GetDiscordPayloadFromEvent() (#3184) @Kinglykrab 2023-04-05
• Remove ExportVarComplex() from embparser.cpp/embparser.h (#3282) @Kinglykrab 2023-04-14
• Remove GetQGlobal() from qglobals.cpp/qglobals.h (#3285) @Kinglykrab 2023-04-14
• Remove IsFullHP from mob.cpp/mob.h (#3277) @Kinglykrab 2023-04-14
• Remove IsMeleeDmg() from skills.cpp/skills.h (#3279) @Kinglykrab 2023-04-14
• Remove _GetMovementSpeed() from mob.h (#3276) @Kinglykrab 2023-04-14
• Remove always true condition in Strings::Commify() (#3193) @Kinglykrab 2023-04-05
• Remove always true conditions and unreachable code in Client::SendMercPersonalInfo() (#3258) @Kinglykrab 2023-04-05
• Remove always true statement in say_link.cpp (#3188) @Kinglykrab 2023-04-05
• Remove always true statements in task_client_state.cpp (#3292) @Kinglykrab 2023-04-14
• Remove always true/false conditions from bot.cpp (#3237) @Kinglykrab 2023-04-05
• Remove bool return from GetSharedPlatinum() (#3191) @Kinglykrab 2023-04-05
• Remove extra assignment of current_endurance in Client ctor (#3261) @Kinglykrab 2023-04-05
• Remove extraneous check for NegateAttacks in SE_NegateAttacks (#3228) @Kinglykrab 2023-04-05
• Remove extraneous parentheses around math in Mob::ApplySpellsBonuses() (#3227) @Kinglykrab 2023-04-05
• Remove getd(), geti(), InUse(), lasterr(), my_get_sv(), and VarExists() in embperl.cpp/embperl.h (#3283) @Kinglykrab 2023-04-15
• Remove item_timers from questmgr.cpp/questmgr.h (#3286) @Kinglykrab 2023-04-14
• Remove pendinggroup from mob.h (#3278) @Kinglykrab 2023-04-14
• Remove position_same_update_count from client.cpp/client.h (#3280) @Kinglykrab 2023-04-14
• Remove unnecessary break in while loop in Mob::AddToHateList() (#3219) @Kinglykrab 2023-04-05
• Remove unnecessary check for IsStackable() in DeleteItem() (#3186) @Kinglykrab 2023-04-05
• Remove unnecessary condition and cleanup variable name in tasks.cpp (#3293) @Kinglykrab 2023-04-14
• Remove unnecessary conditions in Client::Consume() (#3265) @Kinglykrab 2023-04-05
• Remove unnecessary conditions in Client::FilteredMessageCheck() (#3262) @Kinglykrab 2023-04-05
• Remove unnecessary conditions in Client::SendFactionMessage() (#3267) @Kinglykrab 2023-04-05
• Remove unnecessary setting of reuse variable in Bot::DoClassAttacks() (#3233) @Kinglykrab 2023-04-05
• Remove unused SetConfigFile in common/eqemu_config.h (#3208) @Kinglykrab 2023-04-05
• Remove unused code in eq_packet.cpp/eq_packet.h (#3183) @Kinglykrab 2023-04-05
• Remove unused ctor and use default dtor in xtargetautohaters.h (#3290) @Kinglykrab 2023-04-14
• Remove unused macros in common/types.h (#3194) @Kinglykrab 2023-04-05
• Remove unused variable in Database::CopyCharacter() (#3197) @Kinglykrab 2023-04-05
• Remove unused variables and use reference in task_manager.cpp (#3291) @Kinglykrab 2023-04-14
• SE_AttackSpeed3 effect_value is always less than 0 (#3222) @Kinglykrab 2023-04-05
• SE_StrikeThrough and SE_StrikeThrough2 are the same in bonuses.cpp (#3223) @Kinglykrab 2023-04-05
• Set bonuses to use spell ID instead of boolean (#3230) @Kinglykrab 2023-04-05
• Use .clear() and .empty() instead of comparing to empty string or setting to empty string in CheckDatabaseConvertPPBlob() (#3201) @Kinglykrab 2023-04-05
• Use .clear() instead of setting string to empty in eqemu_command_handler.cpp (#3195) @Kinglykrab 2023-04-05
• Use .empty() in Client::ScribeSpells() and Client::LearnDisciplines() (#3259) @Kinglykrab 2023-04-05
• Use constant reference and check for empty string properly in dbcore.cpp (#3203) @Kinglykrab 2023-04-05
• Use default ctor instead of an empty ctor. (#3206) @Kinglykrab 2023-04-05
• Use default dtor instead of empty dtor for EQTime in eqtime.cpp/eqtime.h (#3210) @Kinglykrab 2023-04-05
• Use variable for c->GetTarget() instead of calling multiple times in bot_command.cpp (#3254) @Kinglykrab 2023-04-05
• Use variable for character instead of a loop (#3268) @Kinglykrab 2023-04-05
• Utilize .empty() instead of checking for an empty string in Database::ReserveName() (#3198) @Kinglykrab 2023-04-05
• Utilize IsTaunting(), SetPetPower(), SetPetType(), and SetTaunting() (#3275) @Kinglykrab 2023-04-15
• Validate for nullptrs in bot.cpp (#3232) @Kinglykrab 2023-04-05
• other is always defined in these cases in attack.cpp (#3217) @Kinglykrab 2023-04-05
• results variable is assigned but never used in SaveCharacterCreate() (#3180) @Kinglykrab 2023-04-05

Crash

• Add additional raid integrity checks on Bot Spawn. (#3295) @Aeadoin 2023-04-16
• Fix crash with uninitialized item instance, and Bot timeout (#3296) @Aeadoin 2023-04-15
• Resolve crash due to uninitialized pointer. (#3271) @Aeadoin 2023-04-08

Feature

• Make ornamentations work with any augment type (#3281) @Kinglykrab 2023-04-16

Fixes

• Camping was causing player to leave raid, causing unexpected behavior (#3299) @Aeadoin 2023-04-22
• Resolve loading of inventory (#3272) @Aeadoin 2023-04-08

Quest API

• Add ApplySpellRaid() and SetSpellDurationRaid() to Bots in Perl/Lua (#3274) @Kinglykrab 2023-04-09
• Add GetBuffSpellIDs() to Perl/Lua (#3273) @Kinglykrab 2023-04-09
• Fix LDoN Methods in Perl/Lua (#3287) @Kinglykrab 2023-04-10

Rules

• Optional summoning when already in melee range (#3204) @trentdm 2023-04-08

Telnet

• Telnet encoding fix (#3269) @Akkadius 2023-04-05

Code

• Add client pointer validation to Zone::GetClosestZonePoint() (#3173) @Kinglykrab 2023-04-01
• Change level to bot_level in Bot::DoClassAttacks() to not overlap member variable (#3239) @Kinglykrab 2023-04-03
• Cleanup unnecessary string -> char* -> string conversions in eqemu_config.cpp (#3207) @Kinglykrab 2023-04-03
• Cleanup uses of insert/push_back when a temp object is used. (#3170) @Aeadoin 2023-04-03
• Cleanup variable names in Bot::AddSpellToBotList() (#3248) @Kinglykrab 2023-04-03
• Explicitly cast to float for more precision in Bot::GenerateBastHitPoints() (#3238) @Kinglykrab 2023-04-03
• Fix SEResist array settings duplicate code (#3225) @Kinglykrab 2023-04-03
• Fix loop and code duplication for SE_ProcOnKillShot (#3224) @Kinglykrab 2023-04-03
• Fix possible dereferencing of invalid iterator in constants (#3181) @Kinglykrab 2023-04-03
• Fix typo where itembonuses should have been used instead of spellbonuses (#3221) @Kinglykrab 2023-04-03
• Further bot.cpp nullptr checks (#3240) @Kinglykrab 2023-04-03
• Move cases in Bot::AICastSpell() (#3247) @Kinglykrab 2023-04-03
• Multiple cases same outcome and set skip variable to same value (#3216) @Kinglykrab 2023-04-03
• Multiple cases with same outcome in GetGMSayColorFromCategory() (#3182) @Kinglykrab 2023-04-03
• Remove extraneous loottable_id setting in WakeTheDead in aa.cpp (#3215) @Kinglykrab 2023-04-03
• Remove possible dereferenced nullptrs in bot.cpp (#3241) @Kinglykrab 2023-04-03
• Remove unnecessary >= 0 checks for procs in botspellsai.cpp (#3242) @Kinglykrab 2023-04-03
• Remove unnecessary botCaster check in Bot::GetDebuffBotSpell() (#3246) @Kinglykrab 2023-04-03
• Remove unnecessary group validation in Bot::Death() (#3235) @Kinglykrab 2023-04-03
• Remove unnecessary hpr checks in Bot::BotCastHeal() (#3245) @Kinglykrab 2023-04-03
• Remove unnecessary setting of spell_type_index in Bot::GetChanceToCastBySpellType() (#3243) @Kinglykrab 2023-04-03
• Remove unnecessary skill_to_use check in Bot::DoClassAttacks() (#3236) @Kinglykrab 2023-04-03
• Remove unnecessary spell_list validation check in botspellsai.cpp (#3244) @Kinglykrab 2023-04-03
• Remove unnecessary validation check in Zone::ClearBlockedSpells() (#3172) @Kinglykrab 2023-04-01
• Remove unused Includes under zone files (#3162) @Aeadoin 2023-04-02
• Remove unused query variable in Database::DeleteInstance() (#3202) @Kinglykrab 2023-04-03
• Unconditional return in for loop in GetRaidByCharID() (#3179) @Kinglykrab 2023-04-03
• Use a constant reference for content_flags in SetContentFlags() (#3196) @Kinglykrab 2023-04-03
• Wake The Dead argument was named the same as a member variable in Mob (#3214) @Kinglykrab 2023-04-03
• gid is assigned 2 values simultaneously in bot.cpp (#3234) @Kinglykrab 2023-04-03
• summon_count > MAX_SWARM_PETS is always false in aa.cpp (#3212) @Kinglykrab 2023-04-03

Fixes

• Correct Forward Declaration compilation warning (#3176) @Aeadoin 2023-04-02
• Fix issue with Bot Raid invites not working. (#3249) @Aeadoin 2023-04-03

Performance

• Change to use Pass by reference where valid. (#3163) @Aeadoin 2023-04-02

Bots

• Remove Bot Groups Functionality (#3165) @Aeadoin 2023-04-01

Code

• Cleanup excessive type casting: string -> char * -> string (#3169) @Aeadoin 2023-04-01

Crash

• Add Checks for valid pointers or fix existing. (#3164) @Aeadoin 2023-04-01
• Fix out of bound arrays, other potential crashes (#3166) @Aeadoin 2023-04-01

Fixes

• Correct SE_SlayUndead & SE_HeadShotLevel limit Value when applied. (#3171) @Aeadoin 2023-04-01
• Prevent VerifyGroup from setting OOZ membername to Null character. (#3168) @Aeadoin 2023-04-01

Quest API

• Add missing Luabind definitions to lua_general.cpp (#3167) @Kinglykrab 2023-04-01