simorgh

ENH: use local BFF (#11163) * ENH: use local BFF * FIX: linting errors * FIX: ts errors * FIX: ts errors * FIX: yet more ts errors * Type optHeaders * FIX: fix for test suites * FIX: ts error * ENH: aaron%27s magic suggestion --------- Co-authored-by: Aaron Moore [email protected]

Update to Next.js 14 + set pageType for WebVitals (#11165) * Update to Next.js 14 * Add type to Next.js pageData response for WebVitals * typo * Update to 14.0.1

Merge pull request #11148 from bbc/WSTEAM1-623-vj-embeds-amp WSTEAM1-623: Render VJ Embeds on .AMP

Merge pull request #11166 from bbc/flourish-height-padding-fix WSTEAM1-688: Fix for cropped embeds (tested on preview)

Merge pull request #11150 from bbc/WSTEAM1-245-amp-cookie-banner-ally WSTEAM1-245 AMP: Cookie banner needs to meet a11y %27focus not obscured%27 guideline

Merge pull request #11161 from bbc/WSTEAMA-876-amend-radio-schedule-to-match-designs WSTEAMA-876 - Amend Radio Schedule to match UX designs

Merge pull request #11139 from bbc/WSTEAMA-837-add-Nabeel-to-maintainers WSTEAMA-837 added Nabeel to maintainers

Merge pull request #11156 from bbc/WSTEAMA-840-update-livelabel-css-to-use-teal WSTEAMA-840 - Update LiveLabel CSS to use Teal

Surface BFF fetch 404s (#11164)

Fix Next.js local standalone build (#11157) * Fix Next.js local production build * Move into separate command

Add Github Actions workflow permissions (#11160) * Add Github Actions workflow permissions * Update simorgh-misc-checks.yml * try pull-requests * Update simorgh-misc-checks.yml * Test write-all for elimination * combo01 * Update simorgh-misc-checks.yml * Update simorgh-misc-checks.yml * Update simorgh-misc-checks.yml * Update simorgh-misc-checks.yml * Update simorgh-misc-checks.yml * Metadata is not valid apparently. * Update simorgh-misc-checks.yml * Set status for misc-checks * Test read for statuses permission * Revert "Test read for statuses permission" This reverts commit a1d030c908f9c1e0ff4efc34b1296fea431ae362. * Update simorgh-release-asset.yml

Merge pull request #11151 from bbc/WSTEAMA-844-removes-amphtml-from-homepages WSTEAMA-844: Removes amphtml from homepages

WSTEAM1-659: Add iFrame component (#11149) * WSTEAM1-659: Add iFrame component * WSTEAM1-659: Update imports * WSTEAM1-659: Refactor * WSTEAM1-659: Refactor * WSTEAM1-659: Refactor * WSTEAM1-659: Update name * WSTEAM1-659: Change import path

Merge pull request #11146 from bbc/WSTEAMA-817-add-live-label-to-live-promos-on-the-homepage WSTEAMA 817 Add LiveLabel to live promos on the homepage

Fix unit test warnings (#10541) * fix: %27Warning: Failed prop type: Invalid prop script of type object supplied to Byline, expected string.%27 * fix: Warning: Failed prop type: The prop id is marked as required in LinkContents, but its value is null. * fix: Warning: Failed prop type: Invalid prop children of type object supplied to PodcastPromo, expected an array. * Adding css as a prop to the ChunkExtractorManager Clatty hack to remove: %27console.error Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it%27s defined in, or you might have mixed up default and named imports.%27 warning from the console. This is because the emotion cache provider requires all React elements to have a css attribute 🤷 * fix: suppress %27Warning: Failed prop type: Invalid prop listIndex of type string supplied to MostReadRank, expected number * fix: %27Warning: Failed prop type: Invalid prop content of type array supplied to RelatedContentSection, expected object%27 * fix: Warning: Failed prop type: Invalid prop links[3] of type array supplied to PodcastExternalLinks, expected object * Fix prop types for children and aria on the PodcastExternalLink * fix: %27Warning: Failed prop type: Cannot read properties of null (reading %27type%27)%27 - remove null block from list * Fix %27 Warning: Failed prop type: The prop timestamp is marked as required in TimestampContainer, but its value is undefined.%27 * Fix: Warning: Failed prop type: Invalid prop content of type object supplied to RelatedContentSection, expected an array. * Fix: Warning: Failed prop type: Invalid prop blocks of type object supplied to ScrollablePromo, expected an array. * Fix %27Warning: Failed prop type: The prop position is marked as required in Curation, but its value is undefined.%27 * Suppress %27Warning: Failed prop type: Missing required props: altText%27 * Fix unit test * Fix unit test * Fix: %27Warning: Failed prop type: Invalid prop service of type object supplied to LiveLabel, expected string.%27 * Fix %27Warning: Failed prop type: Invalid prop id of type number supplied to ProgramCard, expected string.%27 * Fix: %27Warning: Failed prop type: The prop onClick is marked as required in Promo, but its value is undefined. * Fix: Warning: Failed prop type: The prop script is marked as required in TimestampContainer, but its value is undefined. Warning: Failed prop type: The prop service is marked as required in TimestampContainer, but its value is undefined. by wrapping the scrollable promo component in a ServiceProviderContext * Suppress %27Warning: Failed prop type: The prop dataAttribute.data-cookie-banner is marked as required in RejectButton, but its value is undefined. * Fix: %27Warning: Failed prop type: The prop id is marked as required in AmpSocialEmbed, but its value is undefined. * Suppress prop type warnings * Suppress %27Warning: Failed prop type: The prop dataAttribute.data-cookie-banner is marked as required in RejectButton, but its value is undefined.%27 * Suppress: Warning: Failed prop type: The prop optimizely is marked as required in ForwardRef, but its value is null Fix: Warning: Failed prop type: Invalid prop items[3] of type string supplied to CpsRecommendations, expected object by using an empty object instead of an empty string * Suppress: Warning: Failed prop type: The prop linkId is marked as required in StyledBrand, but its value is null * Fix: %27Warning: Failed prop type: Invalid prop promo supplied to RecommendationsPromo%27 by allowing multiple promo prop type in RecommendationsPromo * Suppressing multiple prop type warnings * Revert "fix: Warning: Failed prop type: The prop id is marked as required in LinkContents, but its value is null." This reverts commit e590931b2d928a8e9c47e62332c130d95cdb3a10. * Suppress: Warning: Failed prop type: The prop service is marked as required in LiveLabel, but its value is undefined * Fix janky console logs when starting up the server * Suppressing multiple prop warnings * Suppress %27Warning: Failed prop type: Invalid prop blocks[0].type of value urlLink supplied to BulletedListContainer, expected one of ["listItem"]%27 * Suppress %27Warning: Failed prop type: The prop image.height is marked as required in FrostedGlassPromo, but its value is undefined%27 * Suppress %27Warning: Failed prop type: Invalid prop listIndex of type string supplied to MostReadRank, expected number%27 * Suppress multiple prop warnings * Suppress Warning: Failed prop type: Image: prop type useLargeImages is invalid; it must be a function, usually from the prop-types package, but received undefined.This often happens because of typos such as PropTypes.function instead of PropTypes.func * Suppress Warning: Failed prop type: The prop ariaId is marked as required in Bulletin, but its value is undefined * Suppress "Warning: Failed prop type: The prop optimizely is marked as required in ForwardRef, but its value is null" * Suppress %27Warning: Failed prop type: The prop dataAttribute.data-cookie-banner is marked as required in RejectButton, but its value is undefined%27 * Suppress %27Warning: Failed prop type: The prop aria.aria-labelledby is marked as required in PodcastExternalLink, but its value is undefined%27 * Suppress Warning: Failed prop type: The prop service is marked as required in LiveLabel, but its value is undefined * Suppress: - Warning: Failed prop type: The prop service is marked as required in Message, but its value is undefined - Warning: Failed prop type: The prop service is marked as required in AmpMediaPlayer, but its value is undefined * Suppress multiple prop type warnings * Suppress linkId prop type warnings warnings * Suppress Warning: Failed prop type: The prop dataAttribute.data-cookie-banner is marked as required in RejectButton, but its value is undefined * Suppress %27Warning: Failed prop type: Invalid prop children of type array supplied to PodcastPromo, expected a single ReactElement.%27 * Suppress %27Warning: Failed prop type: The prop source is marked as required in Facebook, but its value is null%27 * Fix linting issue * Suppress Warning: Failed prop type: The prop optimizely is marked as required in ForwardRef, but its value is null. * Fix linting * Ensure tests fail immediately if props type warnings not addressed * Suppress: Story Page › should only render firstPublished timestamp for Igbo when lastPublished is less than 1 min later Test failed because a React warning was detected. Please fix the following: Warning: Failed prop,The prop id is marked as required in LinkContents, but its value is null., * Suppress %27Warning: Failed prop type: The prop id is marked as required in LinkContents, but its value is null.%27 * Suppress: Front Page › Assertions › should render visually hidden text as h1 Test failed because a React warning was detected. Please fix the following: Warning: Failed prop,The prop id is marked as required in LinkContents, but its value is null., * Suppress Story Promo Link Contents › encountered a declaration exception Test failed because a React warning was detected. Please fix the following: Warning: Failed prop,The prop id is marked as required in LinkContents, but its value is undefined., at LinkContents (/home/runner/work/simorgh/simorgh/src/app/legacy/containers/StoryPromo/LinkContents/index.jsx:12:25) type: %s%s * Fix: defaultPageWrapper › should render default page wrapper with children Test failed because a React warning was detected. Please fix the following: Warning: Failed prop,The prop status is marked as required in PageWrapper, but its value is undefined., Suppress: defaultPageWrapper › should render default page wrapper with children Test failed because a React warning was detected. Please fix the following: Warning: Failed prop,The prop dataAttribute.data-cookie-banner is marked as required in RejectButton, but its value is undefined., * Default page type to WS-ERROR-PAGE if there%27s a 400 / 500 status, or no page data * Default WebVitals page type to WS-UNKNOWN-PAGE if there is a non 400/500 status, but no page data (which is only likely to occur in test data) * Remove unused import * Suppress Promo component - Image › should render image using correct resolution and no large image on desktop Test failed because a React warning was detected. Please fix the following: Warning: Failed prop,Image: prop type useLargeImages is invalid; it must be a function, usually from the prop-types package, but received undefined.This often happens because of typos such as PropTypes.function instead of PropTypes.func., * Suppress ProgramCard › encountered a declaration exception Test failed because a React warning was detected. Please fix the following: Warning: Failed prop,The prop id is marked as required in ProgramCard, but its value is undefined., * Suppress MediaIndicator › encountered a declaration exception Test failed because a React warning was detected. Please fix the following: Warning: Failed prop,The prop script is marked as required in MediaIndicator, but its value is undefined., * Suppress Media Player: Amp › encountered a declaration exception Test failed because a React warning was detected. Please fix the following: Warning: Failed prop,The prop noJsMessage is marked as required in AmpMediaPlayer, but its value is undefined., * Suppress multiple prop warnings * Fix: the clattiest hack to prevent Warning: Failed prop,The prop dataAttribute.data-cookie-banner is marked as required in RejectButton, but its value is undefined., Suppression of the warning using suppressPropWarnings does not work - it causes the src/app/legacy/containers/ConsentBanner/index.canonical.test.jsx test to time out (presumably because there is some manipulation of the window object to get cookies playing nicely when testing). * Suppress %27Warning: Failed prop type: The prop id is marked as required in LinkContents, but its value is null.%27 * Suppress %27Warning: Failed prop type: The prop id is marked as required in LinkContents, but its value is null.%27 * Unskip the FIX routes test * Revert "fix: Warning: Failed prop type: Invalid prop children of type object supplied to PodcastPromo, expected an array." This reverts commit 017152ff864e8d9bdf25f3a4f5540e4bffcd3a8e. * Suppress Inline › Should render correctly Test failed because a React warning was detected. Please fix the following: Warning: Failed prop,Invalid prop children of type object supplied to PodcastPromo, expected an array., * Fix linting * PodcastPromo children prop can be a single element, or multiple elements * Fix: linkText is no longer a required prop on the Podcast External Link component * Remove prop type suppression * Attempting to fix some more unit test errors * Suppress Curation warnings * Fix merge conflict * Remove unnecessary import * Revert * Fix unit test failure * Suppress The pseudo class ":nth-child" is potentially unsafe when doing server-side rendering. Try changing it to ":nth-of-type". errors * Do not render the media icon if the promo is not of a video/audio or photogallery promo * Fix typescript error * Remove unused import * Suppress prop warnings & ensure isApp is set to false by default * suppress optimizely warnings * Fix test * Suppress prop warning * Suppress prop warning * Suppress prop warning * Fix useLargeImages typing issue * Suppress prop warning * Suppress prop warning * Fix test * Update snapshot as a result of updating test * Fix test * Fix tests - some prop suppressions no longer required * Remove unused import * Suppressions no longer required * Suppress prop warningsx * Suppress prop warning for mediaicon * Suppress prop warning * Suppress prop warning * Suppress prop warning * Fix whitespace * Suppress prop warning no longer required * Supress prop warnings * Fix suppressions * Fix duplicate imports * add pageType to pageWrapper tests to stop web vitals error * tidy * return to wanted error message * comment out test to see if it is causing web vitals warnings * try with warning when pagetype is present * webvitals-not-on-error-pages * added act() to remove unit test erros from story pages, plus snapshot update * article page tests use act() * Semi-revert WebVitals changes - we want tests to fail if we there is no page type set for a page which uses Web Vitals * Adding comments * Remove console log * Replace references of ReactDom.render * Replace references of ReactDom.render * Replace references of ReactDom.render * Add "ReactDOM.render is no longer supported in React 18" to this list of errors * Ensure tests fail if act is required but not implemented in tests * Update snapshots since test structure has been updated, and a new top level describe added * Simplify test * Ensure tests fail if no page type provided for the Web Vitals component * Simplify page data props * Fix WebVitals test * Update src/app/pages/StoryPage/index.test.jsx Co-authored-by: Karina Thomas [email protected] * Update src/app/pages/StoryPage/index.test.jsx Co-authored-by: Karina Thomas [email protected] * Add missing closing brackets * Fix article page & associated tests * Metadata type should be mandatory on PageLayoutWrapper * Fix route tests * Suppress prop warnings * Fix error test * Fix Homepage tests * Include test path & name in the output * Fix test * Tidy up error message * Suppress props * Revert "Fix Homepage tests" This reverts commit 705da8ea446b6f8e83ef750647bedbca40633067. * Fix homepage tests * Add metadata type to the error page * Downgrade ATI Event Tracking error message to a warning * Fix test * Fix test * Remove unnecessary mocking * Move suppression of prop warnings to main test * Remove css property as it is causing lint issues * Update react warning text * Mock ChunkExtractorManager correctly, in order to fix tests * Do not permit any console errors in the tests - they must be fixed or suppressed * Mock console error otherwise test will fail * Mock the console error, otherwise the test will fail * If pageType is unknown, return an empty function * Remove references to console.error as it is no longer required * Fix test * Fix other test * Use colors instead of chalk, as upgrading to ESM stops unit tests running * Reinstate chalk * Use colours instead of chalk * Fix dependency check script to include the name of the dependency * Add colors package * Fix routes tests * Fix import order * Allow console errors * Remove console.log * Add a timeout? 🤷 * Skip test as it is consistently failing in CI but passing locally 😭 * FIX: missing snapshot from previous commit * FIX: fix route unit tests * FIX: fix ATI analytics unit tests * ENH: add topic data with pagination * FIX: pagination unit tests plus test one area of simorgh * FIX: linting errors --------- Co-authored-by: Toby Cox [email protected] Co-authored-by: LilyL0u [email protected] Co-authored-by: LilyL0u [email protected]

Prevent @types/ramda package updates (#11153) * Update renovate.json * Update renovate.json

Update all 3rd party patch dependencies (#11137) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Merge pull request #11142 from bbc/WSTEAMA-839-live-promo-fixture-data WSTEAMA-839: Update homepage fixture data to include live promo

WSTEAMA-618: ESM Dependency Script (#11099) * get type from dep * script and readme * FIX: sort out bad merge * csv * fix async bug * FIX: one thing slipped through bad merge * readme instruction * Update scripts/README.md Co-authored-by: Karina Thomas [email protected] * Update scripts/README.md Co-authored-by: Karina Thomas [email protected] * Update scripts/README.md Co-authored-by: Karina Thomas [email protected] * Update scripts/esmDependencyCheck.js Co-authored-by: Karina Thomas [email protected] * use github token in zshrc instead * typo * deals with patch version strings * linting * simplified date format * clean up console logs * ENH: add sorting and notes * Revert ENH: add sorting and notes * Revert Revert ENH: add sorting and notes * ENH: update to node18 // discard node-fetch --------- Co-authored-by: LilyL0u [email protected] Co-authored-by: LilyL0u [email protected] Co-authored-by: Karina Thomas [email protected]

Merge pull request #11127 from bbc/WSTEAMA-831-refactor-livelabel WSTEAMA-831 - Refactor LiveLabel to include translations of on and offscreen text