penthouse

#320 - check if viewport is defined (thanks simllll)
#343 - fix crashes when element doesn't have style attribute (thanks lucasrla)

#344 - add page goto option for puppeteer (thanks bv-sumit)

And dependabot upgrades. See all changes:
https://github.com/pocketjoso/penthouse/compare/v2.3.2...v.2.3.3

#310 - fixes incorrect case sensitivity for font-family declarations, which could cause @font-face declarations to be incorrectly filtered out from the critical css, when usage had non-matching case.

#305 - interceptedRequest.url should be a function call
#303 - fix(browser): call getBrowser each time

#302 - bump puppeteer. (to 2.1.1)

Note: Advised minimum node version (package.json.engines) was increased from 8 to 8.16.

see #300 for details.

Also included dependency security fix: #297

#291 - Properly test min-max media queries for critical CSS inclusion

(dev) dependency upgrades.

Released as [email protected].

Minor Changes

• #284: allowedResponseCode option implemented
• #289: added forceExclude option
• #290: package upgrades, including [email protected]

End of life for Node 6 is coming soon, bumping minimum required node version to 8.
To keep using penthouse on Node 6, stay on an 1.x version.

most notably [email protected].

de57e060737681e7b8e50d12f658cee9a402e25e - handle uncaught exceptions from launching puppeteer browser

Just taking the latest release from puppeteer.
https://github.com/pocketjoso/penthouse/commit/68976e45c8817db536ef76f1f60c8f9bf947fd65

Fixes a race condition issue where the browser instance penthouse re-uses between parallel executions could be closed unexpectedly. See https://github.com/pocketjoso/penthouse/pull/279 for more details.

Patches

• Internal job counter determining if should close browser: 8dbfb39fac199974d21b20f20a39374ae7276ff2
• Fix: rm unused argument: 88ee53d6c1fc630ebf0f72e2725ff835440837aa

Minor Changes

• Add support for cookies: 7b88f33af8f4b99c8649c4cfc4736471476d60ab

Patches

• Bugfix: ensure rejecting if puppeteer page crashes: cb51e9edc543baf819a8ea2261229b46e2a1d4c8

One of the things the renderWait prop can be useful for is to wait extra for things to load before taking the first screenshot. For no particular reason this was not possible before (the screenshot was taken before renderWait - now this was changed.

Patches

• Update deps: 6bfdb8367c940bd524ac3731de195a5a74c73208
• Wait for renderWait before taking before screenshot: b66924fd26d7e99af5fb439321accdaca72d764b

Bumping minor because of 28f39f15315950e1c8f6eebed09fdc81446aafee:
Penthouse used to override and set exit code 0 via exit listeners, even if parent process was killed with another exit code. Someone could have relied on this, although I would argue it's a bug. Now Penthouse no longer overrides the exit code.

Minor Changes

• Exit handler, re-use exit code: 28f39f15315950e1c8f6eebed09fdc81446aafee

Patches

• Ensure process listeners are removed: 635f45c4a3ef1dd9c91d003a4a2aeb0c1b4e2929
• Bug: puppeteer timeout was not muted in some cases: a7356eac87663e840facaf6bcc835b8a1a4ddc18

Primarily a puppeteer upgrade to 1.8.0.

Patches

• Update dev deps: 422c6cdb347dc1eb8361255c151cffb3c403bc4b
• [email protected]: 9ca14ddf80b3776f772c2ae192cfabf1b1bdb900
• Remove previous puppeteer workaround, no longer needed: 0ef8eced5940aa65480cccc45869be7bdacf9f62

Patches

6c8a5ab workarkound for https errors and setRequestInterception problems (origin/timeout-fixes)
fe64f9b core: avoid further execution when process has timed out
27a3db4 core: align promise.resolve usage
cf00864 reset reused pages after errors
8359510 core: fully disable puppeteer navigation timeouts

Had to downgrade puppeteer, and re-wrote puppeteer browser handling. Penthouse now re-uses the page puppeteer launches with, and is capable of re-using pages between penthouse calls (only used in unstableKeepAlive mode, for now).

Minor Changes

• Downgrade to [email protected]; 1.7 causes new timeouts for some sites: 99f1a038a2560d15e4bb701a4a5909b4608c036f

Raised an issue for this here:
GoogleChrome/puppeteer#3118

• In unstableKeepBrowserAlive mode, re-use prev opened browser page: 086a1b5b530ca7b7ca01fd8f0d7eba7edc7ec377

Patches

• Mv browser page open calls: c3f1ffa2cdd09e30f79067f05bf41d2ce1258c1e
• Mv page.close calls: 7363632ce829f3182b8704dbe878d3f2b9442416
• Separate code managing browser, including browser pages: 8268eeffdb56b0e7a05079dc9a24ba7e3da3b300
• Browser: use Puppeteer for counting browser pages: c2c4faa97f0d4a8148afcceeea1fec9170964cd4
• Tests: rm case no longer applicable: 065753e0fc41f2ca8d6b3488b6566f9ca66a530a

Primarily dependency upgrades. Patched twice as I tagged the wrong branch and this was the easiest solution. 🙃

Patches

• Merge pull request #269 from pocketjoso/puppeteer-1.7-default-viewport: 8a8eb0df1d68914cbf6021d9c30c4052588c9831
• Take puppeteer bug fix: 0881697aff6d600ba95da19a1dc2450b84637024

#267 -package upgrades, including [email protected]. Also bumped minimum Node requirement to 6.14, and fix a babel warning (regarding specifying node format as a float, instead of string).