mu_feature_uefi_variable

Project Mu - Feature Repo - UEFI Variables

OTHER License

Stars
5
Committers
4

Bot releases are visible (Hide)

mu_feature_uefi_variable - v0.1.0 Latest Release

Published by github-actions[bot] over 1 year ago

What's Changed

  1. Removes the PR template from the old location (repo root). File sync
    will track this file in the .github directory now.
  2. Removes issue templates. Issue forms will be auto synced from mu_devops
    now.
  • Breaking change?
    • Will this change break pre-existing builds or functionality without action being taken?
      No

How This Was Tested

Code review.

Integration Instructions

N/A

Signed-off-by: Michael Kubacki [email protected]


Closes #32

Since GitHub treats workflows triggered from forks (and Dependabot) as
untrusted, they receive a read-only GITHUB_TOKEN and the PRs cannot
access any secrets in the repository.

A secret token is required with project write access for the add-to-project
action to automatically assign issues and PRs to a project.

More information:
https://github.blog/changelog/2021-02-19-github-actions-workflows-triggered-by-dependabot-prs-will-run-with-read-only-permissions/

The trigger type could be changed to pull_request_target which would
grant permission to the secret token:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

But that has security implications as described here:
https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

In the end, we'll just remove the action for pull requests for now and only have
issues automatically get assigned to the project upon creation.

How This Was Tested

Verified actions/add-to-project no longer triggers on pull requests.

Integration Instructions

N/A

Signed-off-by: Michael Kubacki [email protected]


Closes #24

Adds a workflow to use the add-to-project GitHub action.

The project-automation.yml file added in this change does not do any filtering so
all new issues and pull requests will automatically be added to the
"Project Mu UEFI Variables" project.

The Project URL is:
https://github.com/orgs/microsoft/projects/479

How This Was Tested

Verified GitHub action in PR.

Integration Instructions

N/A

Signed-off-by: Michael Kubacki [email protected]


Adds a minimal amount of source code to compile so CodeQL can find build output and not produce an error.

The component built in this change can be removed when another actual component is added.

How This Was Tested

Verified CI build locally.
Verified CodeQL GitHub action in PR results.

Integration Instructions

N/A

Signed-off-by: Michael Kubacki [email protected]


Closes #5

Adds an empty package that builds successfully.

This provides a foundation for future code changes and allows CI to be put in place around the build.

How This Was Tested

  1. Verified the following commands return successfully:
    1. stuart_ci_setup -c .pytool/CISettings.py
    2. stuart_update -c .pytool/CISettings.py
    3. stuart_ci_build -c .pytool/CISettings.py
    4. stuart_update -c .pytool/CISettings.py -p VariablePkg
  2. Verified build with build command: build -p VariablePkg -a IA32 -a X64 -t VS2022

Integration Instructions

VariablePkg can be brought into a consumer repo as a dependency now but that is not very
useful as the package is not populated yet.

Signed-off-by: Michael Kubacki [email protected]


🚀 Features & ✨ Enhancements

See commit messages for details.

Signed-off-by: Michael Kubacki [email protected]


Closes #22

This document proposes an initial set of design guidance in
preparation for a starting implementation.

How This Was Tested

Error free in markdownlint.

Integration Instructions

N/A


📖 Documentation Updates

Closes #22

This document proposes an initial set of design guidance in
preparation for a starting implementation.

How This Was Tested

Error free in markdownlint.

Integration Instructions

N/A


Adds the initial readme file for the repo.

It currently provides some background on the project, the
TianoCore UEFI variable driver, and some brief contribution
and code of conduct information.

How This Was Tested

Verified restructured text output in GitHub preview

Integration Instructions

N/A - Read the file to gain a better understanding of the repo

Signed-off-by: Michael Kubacki [email protected]


Full Changelog: https://github.com/microsoft/mu_feature_uefi_variable/compare/...v0.1.0