Bot releases are hidden (Show)
Published by jfmengels over 3 years ago
-
Review.Test: The failure message that shows up when the only difference is whitespace will now also show up when the difference includes new lines.
-
Import cycles: The previous version showed shorter import cycles than the compiler. Now they should be as short as possible. Also the error message is similar to the compiler, instead of saying to go check the compiler's error.
Fixes mishandling of the module name lookup table for case expression patterns.
The issue was originally reported over at https://github.com/jfmengels/elm-review-unused/issues/14
Published by jfmengels over 4 years ago
Simpler visitor functions
As a mean to replace withExpressionVisitor and withDeclarationVisitor that have a cumbersome Direction argument and which causes a lot of unnecessary evaluations for a majority of cases (we usually don't care about the "exit" case), there are now 4 for additional visitor variants:
withExpressionEnterVisitorwithExpressionExitVisitorwithDeclarationEnterVisitorwithDeclarationExitVisitor
The withExpressionVisitor and withDeclarationVisitor visitors are from here on deprecated. In the next major version, they will be replaced by their Enter variant which will take their name.
I hereby encourage everyone to use these new functions which should be faster than the ones they are replacing.
This was discussed in https://github.com/jfmengels/elm-review/issues/13 and improved thanks to @sparksp's suggestions.
Performance
We now avoid recomputing the elm.json, README and dependencies visitors if they didn't change and the result of the previous visitor gave the same result. This should make watch mode and fixes faster.
Bug fixes
- There were a few problems with test failure messages, thanks @zwilias for reporting them and investigating.
